Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add full apache license #7049

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add full apache license #7049

wants to merge 2 commits into from

Conversation

lsmith77
Copy link

What do these changes do?

This is a follow-up to #7048, to fix license detection by GitHub.

It seems like the boilerplate isn't meant to be used a the license but rather within source code file:
licensee/licensee#393

Are there changes in behavior for the user?

Fix incorrect use of the Apache 2.0 license, which also means that GitHub can now properly detect the license.

Related issue number

N/A

Checklist

N/A

@@ -179,11 +179,6 @@ recommended for sake of speed).
.. _async-timeout: https://pypi.python.org/pypi/async_timeout
.. _cChardet: https://pypi.python.org/pypi/cchardet

License
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this can confuse licensee
licensee/licensee#554

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #7049 (a6632df) into master (12f56d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7049   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files         103      103           
  Lines       29972    29972           
  Branches     3640     3640           
=======================================
  Hits        29224    29224           
  Misses        567      567           
  Partials      181      181           
Flag Coverage Δ
CI-GHA 97.40% <ø> (ø)
OS-Linux 97.04% <ø> (-0.01%) ⬇️
OS-Windows 95.39% <ø> (ø)
OS-macOS 96.68% <ø> (-0.01%) ⬇️
Py-3.10.8 97.21% <ø> (-0.01%) ⬇️
Py-3.11.0 96.55% <ø> (ø)
Py-3.11.0-rc.2 ?
Py-3.7.15 96.88% <ø> (ø)
Py-3.7.9 95.27% <ø> (ø)
Py-3.8.10 95.17% <ø> (ø)
Py-3.8.14 96.78% <ø> (ø)
Py-3.9.13 95.16% <ø> (ø)
Py-3.9.14 96.57% <ø> (ø)
Py-3.9.15 96.76% <ø> (-0.05%) ⬇️
Py-pypy7.3.9 96.43% <ø> (-0.01%) ⬇️
VM-macos 96.68% <ø> (-0.01%) ⬇️
VM-ubuntu 97.04% <ø> (-0.01%) ⬇️
VM-windows 95.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

LICENSE.txt Outdated Show resolved Hide resolved
@Dreamsorcerer
Copy link
Member

Thanks, looks good to me. I think @asvetlov usually updates these kind of things with a tool that can update all our repositories in one go. Not sure what it is though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants