New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add full apache license #7049
base: master
Are you sure you want to change the base?
add full apache license #7049
Conversation
@@ -179,11 +179,6 @@ recommended for sake of speed). | |||
.. _async-timeout: https://pypi.python.org/pypi/async_timeout | |||
.. _cChardet: https://pypi.python.org/pypi/cchardet | |||
|
|||
License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently this can confuse licensee
licensee/licensee#554
Codecov Report
@@ Coverage Diff @@
## master #7049 +/- ##
=======================================
Coverage 97.50% 97.50%
=======================================
Files 103 103
Lines 29972 29972
Branches 3640 3640
=======================================
Hits 29224 29224
Misses 567 567
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
for more information, see https://pre-commit.ci
Thanks, looks good to me. I think @asvetlov usually updates these kind of things with a tool that can update all our repositories in one go. Not sure what it is though... |
What do these changes do?
This is a follow-up to #7048, to fix license detection by GitHub.
It seems like the boilerplate isn't meant to be used a the license but rather within source code file:
licensee/licensee#393
Are there changes in behavior for the user?
Fix incorrect use of the Apache 2.0 license, which also means that GitHub can now properly detect the license.
Related issue number
N/A
Checklist
N/A