Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6907/0af182ae backport][3.9] docs: Update redis to follow the latest spec #7059

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 30, 2022

This is a backport of PR #6907 as merged into master (0af182a).

What do these changes do?

I changed some Redis code from the documentation to follow the latest API. It is based on redis-py>=4.2.x on which aioredis has been merged and started to be maintained.

Are there changes in behavior for the user?

Nope!

Related issue number

There is no issue related to this PR.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

Thank you for reading and any feedback is always welcomed!

<!-- Thank you for your contribution! -->

## What do these changes do?

I changed some Redis code from the documentation to follow the latest
API. It is based on redis-py>=4.2.x on which aioredis has been merged
and started to be maintained.

## Are there changes in behavior for the user?

Nope!

## Related issue number

There is no issue related to this PR.

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
  * The format is &lt;Name&gt; &lt;Surname&gt;.
  * Please keep alphabetical order, the file is sorted by names.
- [x] Add a new news fragment into the `CHANGES` folder
  * name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
  * ensure type is one of the following:
    * `.feature`: Signifying a new feature.
    * `.bugfix`: Signifying a bug fix.
    * `.doc`: Signifying a documentation improvement.
    * `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."

Thank you for reading and any feedback is always welcomed!

Co-authored-by: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit 0af182a)
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #7059 (2781b96) into 3.9 (6e9ecc7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.9    #7059   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         103      103           
  Lines       30217    30217           
  Branches     3748     3748           
=======================================
+ Hits        29406    29407    +1     
+ Misses        617      616    -1     
  Partials      194      194           
Flag Coverage Δ
CI-GHA 97.21% <ø> (+<0.01%) ⬆️
OS-Linux 96.86% <ø> (+<0.01%) ⬆️
OS-Windows 94.37% <ø> (+<0.01%) ⬆️
OS-macOS 96.48% <ø> (ø)
Py-3.10.8 96.96% <ø> (-0.01%) ⬇️
Py-3.11.0 96.33% <ø> (ø)
Py-3.7.15 96.67% <ø> (ø)
Py-3.7.9 94.22% <ø> (ø)
Py-3.8.10 94.14% <ø> (+<0.01%) ⬆️
Py-3.8.14 96.58% <ø> (ø)
Py-3.9.13 94.15% <ø> (+<0.01%) ⬆️
Py-3.9.14 96.37% <ø> (-0.01%) ⬇️
Py-3.9.15 96.57% <ø> (ø)
Py-pypy7.3.9 96.22% <ø> (+<0.01%) ⬆️
VM-macos 96.48% <ø> (ø)
VM-ubuntu 96.86% <ø> (+<0.01%) ⬆️
VM-windows 94.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_client_functional.py 98.52% <0.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer Dreamsorcerer merged commit 0047a5b into 3.9 Oct 30, 2022
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/0af182ae0ec3980b9164bf0b9ce9a3dc69b5b8ff/pr-6907 branch October 30, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants