Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using event_loop instead loop #7068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Using event_loop instead loop #7068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/testing.rst
View file
Open in desktop
Expand Up @@ -111,11 +111,11 @@ app test client::
body='value: {}'.format(request.app[value]).encode('utf-8'))

@pytest.fixture
def cli(loop, aiohttp_client):
def cli(event_loop, aiohttp_client):
app = web.Application()
app.router.add_get('/', previous)
app.router.add_post('/', previous)
Comment on lines +114 to 117
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def cli(event_loop, aiohttp_client):
app = web.Application()
app.router.add_get('/', previous)
app.router.add_post('/', previous)
async def cli(aiohttp_client):
app = web.Application()
app.router.add_get('/', previous)
app.router.add_post('/', previous)

return loop.run_until_complete(aiohttp_client(app))
return event_loop.run_until_complete(aiohttp_client(app))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return event_loop.run_until_complete(aiohttp_client(app))
return await aiohttp_client(app)

Think it's probably better not to use the loop fixture at all 99% of the time these days.

Github is being too awkward for me to suggest the change in one comment...


async def test_set_value(cli):
resp = await cli.post('/', data={'value': 'foo'})
Expand Down