Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client Brotli support (#5227) #7100

Conversation

ddelange
Copy link
Contributor

(cherry picked from commit 28ea32d)

backport ref #5227 (comment)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 24, 2022
@ddelange ddelange mentioned this pull request Nov 24, 2022
5 tasks
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #7100 (f5df67a) into 3.9 (640bb1e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.9    #7100      +/-   ##
==========================================
- Coverage   97.31%   97.31%   -0.01%     
==========================================
  Files         103      103              
  Lines       30265    30257       -8     
  Branches     3763     3766       +3     
==========================================
- Hits        29452    29444       -8     
  Misses        618      618              
  Partials      195      195              
Flag Coverage Δ
CI-GHA 97.20% <100.00%> (-0.01%) ⬇️
OS-Linux 96.86% <100.00%> (-0.01%) ⬇️
OS-Windows 94.32% <100.00%> (-0.01%) ⬇️
OS-macOS 96.43% <100.00%> (-0.01%) ⬇️
Py-3.10.8 96.91% <100.00%> (-0.01%) ⬇️
Py-3.11.0 96.33% <100.00%> (-0.01%) ⬇️
Py-3.7.15 96.67% <100.00%> (-0.01%) ⬇️
Py-3.7.9 94.18% <100.00%> (-0.01%) ⬇️
Py-3.8.10 94.10% <100.00%> (-0.01%) ⬇️
Py-3.8.14 96.58% <100.00%> (-0.01%) ⬇️
Py-3.9.13 94.10% <100.00%> (-0.01%) ⬇️
Py-3.9.14 96.33% <100.00%> (-0.01%) ⬇️
Py-3.9.15 96.57% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.9 96.18% <100.00%> (+<0.01%) ⬆️
VM-macos 96.43% <100.00%> (-0.01%) ⬇️
VM-ubuntu 96.86% <100.00%> (-0.01%) ⬇️
VM-windows 94.32% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.52% <100.00%> (+0.01%) ⬆️
tests/test_client_request.py 99.60% <100.00%> (+<0.01%) ⬆️
tests/test_web_functional.py 98.09% <100.00%> (-0.02%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ddelange
Copy link
Contributor Author

E       AssertionError: assert '1.0.0.0.0.0.....0.0.ip6.arpa' == 'Mac-1669312225691.local'
E         - Mac-1669312225691.local
E         + 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa

ref https://github.com/aio-libs/aiohttp/actions/runs/3542772584/jobs/5948622150#step:10:402

hmm, is this related to this PR? 🤔

@Dreamsorcerer Dreamsorcerer merged commit 3e7448a into aio-libs:3.9 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants