Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client Brotli support (#5227) #7101

Conversation

ddelange
Copy link
Contributor

(cherry picked from commit 28ea32d)
(cherry picked from commit fab2c62)

backport ref #5227 (comment)

(cherry picked from commit 28ea32d)
(cherry picked from commit fab2c62)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 24, 2022
@ddelange ddelange mentioned this pull request Nov 24, 2022
5 tasks
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #7101 (b44587e) into 3.8 (8cf01ad) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.8    #7101      +/-   ##
==========================================
- Coverage   97.46%   97.39%   -0.07%     
==========================================
  Files         103      103              
  Lines       29964    29956       -8     
  Branches     3059     3060       +1     
==========================================
- Hits        29204    29176      -28     
- Misses        571      591      +20     
  Partials      189      189              
Flag Coverage Δ
CI-GHA 97.26% <100.00%> (-0.07%) ⬇️
OS-Linux 96.90% <100.00%> (-0.12%) ⬇️
OS-Windows 95.16% <100.00%> (+0.41%) ⬆️
OS-macOS 96.00% <100.00%> (?)
Py-3.10.7 ?
Py-3.10.8 96.86% <100.00%> (?)
Py-3.6.15 96.50% <100.00%> (+0.04%) ⬆️
Py-3.6.8 94.75% <100.00%> (-0.01%) ⬇️
Py-3.7.14 ?
Py-3.7.15 96.65% <100.00%> (?)
Py-3.8.10 94.81% <100.00%> (?)
Py-3.8.14 96.56% <100.00%> (-0.06%) ⬇️
Py-3.9.14 ?
VM-macos 96.00% <100.00%> (?)
VM-ubuntu 96.90% <100.00%> (-0.12%) ⬇️
VM-windows 95.16% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_reqrep.py 97.52% <100.00%> (+0.01%) ⬆️
tests/test_client_request.py 99.60% <100.00%> (+<0.01%) ⬆️
tests/test_web_functional.py 97.93% <100.00%> (-0.16%) ⬇️
tests/autobahn/client/client.py 42.85% <0.00%> (-53.58%) ⬇️
tests/test_websocket_parser.py 96.66% <0.00%> (-1.67%) ⬇️
tests/test_test_utils.py 97.10% <0.00%> (-0.83%) ⬇️
tests/test_helpers.py 98.10% <0.00%> (-0.55%) ⬇️
tests/test_client_session.py 98.18% <0.00%> (-0.41%) ⬇️
tests/test_client_ws_functional.py 97.60% <0.00%> (-0.35%) ⬇️
tests/test_streams.py 99.81% <0.00%> (-0.19%) ⬇️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ddelange
Copy link
Contributor Author

E       AssertionError: assert '1.0.0.0.0.0.....0.0.ip6.arpa' == 'Mac-1669312225691.local'
E         - Mac-1669312225691.local
E         + 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa

ref https://github.com/aio-libs/aiohttp/actions/runs/3542772584/jobs/5948622150#step:10:402

hmm, is this related to this PR? 🤔

@Dreamsorcerer
Copy link
Member

Probably best not to push a new feature into a bug fix release. But, I also don't think we'll be doing another 3.8 release anyway.

@webknjaz Think we can do a beta release for 3.9 next week?

@ddelange
Copy link
Contributor Author

Hi @Dreamsorcerer 👋 Any updates on the release? I also asked in the backport PR against 3.9, but no response... It's 6 months later now (and 2.5 years since the original PR), and I would really like to experience the speed-up from this one :)

@ddelange
Copy link
Contributor Author

hi @Dreamsorcerer 👋 is there anything known about the 3.9 release?

@Dreamsorcerer
Copy link
Member

Getting back round to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants