Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using netrc for non-proxy HTTP credentials #7131

Merged
merged 51 commits into from
Mar 17, 2023
Merged

Support using netrc for non-proxy HTTP credentials #7131

merged 51 commits into from
Mar 17, 2023

Commits on Dec 16, 2022

  1. Read HTTP Basic auth from netrc if no explict auth is passed 

    Tries to follow crumbs from
aio-libs#2584 (comment)
    @yuvipanda
    yuvipanda committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2ee2464 View commit details
    Browse the repository at this point in the history

  2. Read from .netrc only when trust_env is passed

    @yuvipanda
    yuvipanda committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2c8e709 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Deduplicate creating basicauth from netrc

    @yuvipanda
    yuvipanda committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    d26d261 View commit details
    Browse the repository at this point in the history

  2. Remove possibly unneeded cast

    @yuvipanda
    yuvipanda committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    f59b4c3 View commit details
    Browse the repository at this point in the history

  3. Cleanup how username & password are determined

    @yuvipanda
    yuvipanda committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    3329055 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Reflow boolean checks to be clearer 

    Co-authored-by: Sam Bull <aa6bs0@sambull.org>
    @yuvipanda @Dreamsorcerer
    yuvipanda and Dreamsorcerer committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    dc7833f View commit details
    Browse the repository at this point in the history

  2. Cleanup netrc parsing code

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    81237e2 View commit details
    Browse the repository at this point in the history

  3. Add tests for netrc helpers

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    11e0969 View commit details
    Browse the repository at this point in the history

  4. Add test for client_req

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    b691694 View commit details
    Browse the repository at this point in the history

  5. Adding self to CONTRIBUTORS

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    cadbbd3 View commit details
    Browse the repository at this point in the history

  6. Add documentation for getting HTTP Basic Auth creds from netrc file

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    fc57968 View commit details
    Browse the repository at this point in the history

  7. Add .feature file

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9bfc648 View commit details
    Browse the repository at this point in the history

  8. Set versionchanged string to 3.9 for HTTP Basic Auth netrc support

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    fd362af View commit details
    Browse the repository at this point in the history

  9. Reword changes file 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1cbf9ab View commit details
    Browse the repository at this point in the history

  10. Use built in tmp_path pytest fixture

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    a8682f1 View commit details
    Browse the repository at this point in the history

  11. Use pytest monkeypatch.setenv

    @yuvipanda
    yuvipanda committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    14be170 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Cleanup tests to use better fixtures

    @yuvipanda
    yuvipanda committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3847daf View commit details
    Browse the repository at this point in the history

  2. Fix comment typo

    @yuvipanda
    yuvipanda committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5074c98 View commit details
    Browse the repository at this point in the history

  3. Use exceptions for control flow

    @yuvipanda
    yuvipanda committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    e3cbf59 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Don't touch netrc if self.url.host is not None 

    While aiohttp client doesn't support relative URLs, this makes
it explicit that netrc is useless if hostname isn't set.
    @yuvipanda
    yuvipanda committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    bfba449 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from yuvipanda/exceptional 

    Use exceptions for control flow
    @yuvipanda
    yuvipanda committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    7f60553 View commit details
    Browse the repository at this point in the history

  3. Encode information about conditional into variable name 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    993675d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Return netrc path from fixture 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    8330097 View commit details
    Browse the repository at this point in the history

  2. Use better rST syntax 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    19dabd3 View commit details
    Browse the repository at this point in the history

  3. Simplify parametrize call 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    8aad3d0 View commit details
    Browse the repository at this point in the history

  4. Simplify parametrize call 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    b556229 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    6ff6ffc View commit details
    Browse the repository at this point in the history

  6. Use a label for boolean condition 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    4722d95 View commit details
    Browse the repository at this point in the history

  7. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    653b93b View commit details
    Browse the repository at this point in the history

  8. Don't write out netrc file in fixture if not passed in 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    4eadd65 View commit details
    Browse the repository at this point in the history

  9. Remove spurious re-import of pathlib

    @yuvipanda
    yuvipanda committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    5f1111a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Use more rST 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e374b90 View commit details
    Browse the repository at this point in the history

  2. Add another rST directive 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    37561cf View commit details
    Browse the repository at this point in the history

  3. Cleanup some unused fixtures 

    Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
    @yuvipanda @webknjaz
    yuvipanda and webknjaz committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    e1c7616 View commit details
    Browse the repository at this point in the history

  4. Use match= for pytest.raises

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    22df825 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8a2f62a View commit details
    Browse the repository at this point in the history

  6. Use match= for pytest.raises *correctly*

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    6932234 View commit details
    Browse the repository at this point in the history

  7. Remove unused netrc_contents

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    273c049 View commit details
    Browse the repository at this point in the history

  8. Hardcode "example.com" as hostname

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    8a8f40b View commit details
    Browse the repository at this point in the history

  9. Cleanup client_request test

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    9b16ad9 View commit details
    Browse the repository at this point in the history

  10. Rename test case

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1d53474 View commit details
    Browse the repository at this point in the history

  11. Split up another test

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    d7ca088 View commit details
    Browse the repository at this point in the history

  12. Split up another test

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    deb4cf7 View commit details
    Browse the repository at this point in the history

  13. Add glossary entry

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    1a72bfb View commit details
    Browse the repository at this point in the history

  14. Add section for environment variables

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    a9fc639 View commit details
    Browse the repository at this point in the history

  15. Fix line length 'error'

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    f8c6562 View commit details
    Browse the repository at this point in the history

  16. Account for netrc_obj being optionally None

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    4a6f050 View commit details
    Browse the repository at this point in the history

  17. Don't use intermediary bools for None checks

    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    524c04d View commit details
    Browse the repository at this point in the history

  18. Merge pull request #3 from yuvipanda/no-intermediaries 

    Don't use intermediary bools for None checks
    @yuvipanda
    yuvipanda committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    53658b0 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Update docs/glossary.rst

    @Dreamsorcerer
    Dreamsorcerer committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    1e40665 View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @yuvipanda
    yuvipanda committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    38a86d9 View commit details
    Browse the repository at this point in the history