Support using netrc for non-proxy HTTP credentials #7249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, setting `trust_env=True` in `ClientSession` will only use the `.netrc` file if present for authentication to proxies. With this change, the credentials will also be used for regular HTTP hosts, and Basic Auth will be sent if an appropriate entry is present in the user's `.netrc` file. PR #7131. Co-authored-by: Sam Bull <aa6bs0@sambull.org> Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com> (cherry picked from commit 6da0469)
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.9 #7249 +/- ##
==========================================
- Coverage 97.34% 97.34% -0.01%
==========================================
Files 107 107
Lines 31490 31544 +54
Branches 3977 4002 +25
==========================================
+ Hits 30654 30706 +52
Misses 634 634
- Partials 202 204 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Dreamsorcerer
deleted the
patchback/backports/3.9/6da04694fd87a39af9c3856048c9ff23ca815f88/pr-7131
branch
|
Thank you so much for doing the cherry-picking, @Dreamsorcerer! |
|
Do you know when a 3.9 might be made? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting
trust_env=TrueinClientSessionwill only use the.netrcfile if present for authentication to proxies. With this change, the credentials will also be used for regular HTTP hosts, and Basic Auth will be sent if an appropriate entry is present in the user's.netrcfile.PR #7131.
Co-authored-by: Sam Bull aa6bs0@sambull.org
Co-authored-by: Sviatoslav Sydorenko webknjaz@redhat.com
(cherry picked from commit 6da0469)
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.