Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about updating headers in on_response_prepare #7283

Merged
merged 3 commits into from May 17, 2023
Merged

Add note about updating headers in on_response_prepare #7283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a85d9d2
Add note about updating headers in on_response_prepare
Dreamsorcerer May 13, 2023
c145aaf
Create 7283.doc
Dreamsorcerer May 13, 2023
66af364
Update web_reference.rst
Dreamsorcerer May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/7283.doc
View file
Open in desktop
@@ -0,0 +1 @@
Added a note about possibly needing to update headers when using ``on_response_prepare`` -- by :user:`Dreamsorcerer`
7 changes: 7 additions & 0 deletions docs/web_reference.rst
View file
Open in desktop
Expand Up @@ -1392,6 +1392,13 @@ duplicated like one using :meth:`~aiohttp.web.Application.copy`.
async def on_prepare(request, response):
pass

.. note::

The headers are written immediately after these callbacks are run.
Therefore, if you modify the content of the response, you may need to
adjust the `Content-Length` header or similar to match. Aiohttp will
not make any updates to the headers from this point.

.. attribute:: on_startup

A :class:`~aiosignal.Signal` that is fired on application start-up.
Expand Down