New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to LLHTTP 9 #7485
Update to LLHTTP 9 #7485
Conversation
@@ -1,4 +1,4 @@ | |||
[submodule "vendor/llhttp"] | |||
path = vendor/llhttp | |||
url = https://github.com/nodejs/llhttp.git | |||
branch = v8.x | |||
branch = main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no v9 branch. So, it looks like we'll be best just leaving it on main, and being sure to checkout a particular tag when updating.
Codecov Report
@@ Coverage Diff @@
## master #7485 +/- ##
==========================================
- Coverage 97.27% 97.27% -0.01%
==========================================
Files 106 106
Lines 31448 31441 -7
Branches 3567 3568 +1
==========================================
- Hits 30592 30585 -7
Misses 652 652
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c0c7508 on top of patchback/backports/3.8/c0c7508b64951b83ea38d232857cc258159f930b/pr-7485 Backporting merged PR #7485 into master
🤖 @patchback |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c0c7508 on top of patchback/backports/3.9/c0c7508b64951b83ea38d232857cc258159f930b/pr-7485 Backporting merged PR #7485 into master
🤖 @patchback |
(cherry picked from commit c0c7508)
(cherry picked from commit c0c7508)
We already have a new version to upgrade to.