Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket connection leak (#7978) #7980

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 18, 2023

(cherry picked from commit 6f1c608)

(cherry picked from commit 6f1c608)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8222403) 97.37% compared to head (53249db) 97.39%.
Report is 1 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #7980      +/-   ##
==========================================
+ Coverage   97.37%   97.39%   +0.02%     
==========================================
  Files         108      108              
  Lines       32541    32564      +23     
  Branches     3847     3850       +3     
==========================================
+ Hits        31687    31716      +29     
+ Misses        652      645       -7     
- Partials      202      203       +1     
Flag Coverage Δ
CI-GHA 97.30% <100.00%> (+0.02%) ⬆️
OS-Linux 96.99% <100.00%> (+0.02%) ⬆️
OS-Windows 94.48% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.81% <100.00%> (+0.21%) ⬆️
Py-3.10.11 94.39% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.77% <100.00%> (+0.02%) ⬆️
Py-3.11.6 96.39% <100.00%> (?)
Py-3.11.7 96.50% <100.00%> (+0.02%) ⬆️
Py-3.12.0 96.44% <100.00%> (?)
Py-3.12.1 96.56% <100.00%> (+0.02%) ⬆️
Py-3.8.10 94.36% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.71% <100.00%> (+0.02%) ⬆️
Py-3.9.13 94.37% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.76% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.13 96.30% <100.00%> (+0.02%) ⬆️
VM-macos 96.81% <100.00%> (+0.21%) ⬆️
VM-ubuntu 96.99% <100.00%> (+0.02%) ⬆️
VM-windows 94.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 477b237 into 3.10 Dec 19, 2023
29 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/6f1c608fe756baa4b82ea8714373cebab0252265/pr-7978 branch December 19, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant