Ensure websocket transport is closed when client does not close it (#8200)

[bdraco]

(cherry picked from commit 6ec4747)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (dd38151) to head (0549a6b).
Report is 3 commits behind head on 3.10.

Additional details and impacted files

@@            Coverage Diff             @@
##             3.10    #8257      +/-   ##
==========================================
+ Coverage   97.46%   97.49%   +0.03%     
==========================================
  Files         108      108              
  Lines       33038    33130      +92     
  Branches     3954     3954              
==========================================
+ Hits        32200    32300     +100     
+ Misses        635      627       -8     
  Partials      203      203              

Flag	Coverage Δ
CI-GHA	97.40% <100.00%> (+0.03%)	⬆️
OS-Linux	97.08% <98.98%> (+0.02%)	⬆️
OS-Windows	94.81% <100.00%> (+0.01%)	⬆️
OS-macOS	96.90% <98.98%> (+0.02%)	⬆️
Py-3.10.11	94.51% <100.00%> (+0.01%)	⬆️
Py-3.10.13	96.61% <98.98%> (+0.03%)	⬆️
Py-3.10.14	96.83% <98.98%> (+0.03%)	⬆️
Py-3.11.8	96.84% <100.00%> (+0.03%)	⬆️
Py-3.12.2	96.82% <100.00%> (+2.43%)	⬆️
Py-3.8.10	94.50% <100.00%> (+0.02%)	⬆️
Py-3.8.18	96.80% <98.98%> (+0.03%)	⬆️
Py-3.9.13	94.51% <100.00%> (+0.01%)	⬆️
Py-3.9.18	96.60% <98.98%> (+0.03%)	⬆️
Py-3.9.19	96.81% <98.98%> (+0.03%)	⬆️
Py-pypy7.3.15	96.38% <98.98%> (+0.02%)	⬆️
VM-macos	96.90% <98.98%> (+0.02%)	⬆️
VM-ubuntu	97.08% <98.98%> (+0.02%)	⬆️
VM-windows	94.81% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

That import time test running with coverage on is a bit useless since coverage is so much slower on 3.12

nevermind, its running isolated. Its a regression in cpython 3.12 taking longer to import

[bdraco]

I was going to mark it @pytest.mark.no_cover but than I realized its just cpython 3.12 taking more time to import which is expected here. Maybe we should increase the time if its > 3.12 instead

[Dreamsorcerer]

nevermind, its running isolated. Its a regression in cpython 3.12 taking longer to import

Do we reckon it'll get improved in a future release?

[Dreamsorcerer]

Maybe we should increase the time if its > 3.12 instead

Can do, or we can skip it on 3.12 for now, if we think it's a temporary regression.

[bdraco]

nevermind, its running isolated. Its a regression in cpython 3.12 taking longer to import

Do we reckon it'll get improved in a future release?

It might be better in 3.13, but from what I gather the timing changes are expected in 3.12 as there were trade-offs to make other things at run time faster

[bdraco]

some more backstory python/cpython#90081 (but there is far more at play)

[Dreamsorcerer]

Well, if coverage is going to affect the performance, we should disable it. That test will have no impact on coverage anyway as it does nothing more than import the library. If that makes a notable difference, then we may want to lower the threshold to match the new timings.

If there is a regression in 3.12 we should probably just skip the test on 3.12. If there's still an issue on 3.13, then we can reevaluate.