Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typing-extensions #8352

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Remove typing-extensions #8352

merged 1 commit into from
Apr 19, 2024

Conversation

Dreamsorcerer
Copy link
Member

This doesn't seem to be needed anymore. We removed this from aiohttp some time ago, and will hopefully have it removed from all our dependencies soon.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot labels Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (c26f356) to head (1fea7ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8352   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         107      107           
  Lines       33092    33092           
  Branches     3887     3887           
=======================================
  Hits        32303    32303           
  Misses        572      572           
  Partials      217      217           
Flag Coverage Δ
CI-GHA 97.53% <ø> (ø)
OS-Linux 97.19% <ø> (ø)
OS-Windows 95.60% <ø> (ø)
OS-macOS 96.86% <ø> (+<0.01%) ⬆️
Py-3.10.11 95.45% <ø> (ø)
Py-3.10.14 97.00% <ø> (+<0.01%) ⬆️
Py-3.11.9 97.19% <ø> (ø)
Py-3.12.3 97.31% <ø> (ø)
Py-3.8.10 95.37% <ø> (ø)
Py-3.8.18 96.85% <ø> (ø)
Py-3.9.13 95.42% <ø> (ø)
Py-3.9.19 96.97% <ø> (ø)
Py-pypy7.3.15 96.51% <ø> (ø)
VM-macos 96.86% <ø> (+<0.01%) ⬆️
VM-ubuntu 97.19% <ø> (ø)
VM-windows 95.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit e8d4b7b into master Apr 19, 2024
39 of 40 checks passed
@Dreamsorcerer Dreamsorcerer deleted the remove-te branch April 19, 2024 18:52
Copy link
Contributor

patchback bot commented Apr 19, 2024

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply e8d4b7b on top of patchback/backports/3.10/e8d4b7b65583ec58cfe09699b5d67b5622ef761b/pr-8352

Backporting merged PR #8352 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.10/e8d4b7b65583ec58cfe09699b5d67b5622ef761b/pr-8352 upstream/3.10
  4. Now, cherry-pick PR Remove typing-extensions #8352 contents into that branch:
    $ git cherry-pick -x e8d4b7b65583ec58cfe09699b5d67b5622ef761b
    If it'll yell at you with something like fatal: Commit e8d4b7b65583ec58cfe09699b5d67b5622ef761b is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x e8d4b7b65583ec58cfe09699b5d67b5622ef761b
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Remove typing-extensions #8352 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.10/e8d4b7b65583ec58cfe09699b5d67b5622ef761b/pr-8352
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer added a commit that referenced this pull request Apr 19, 2024
(cherry picked from commit e8d4b7b)
Dreamsorcerer added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants