Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete size arg from StreamReader.feed_data #7265 #8367

Merged
merged 39 commits into from
Apr 21, 2024
Merged

Conversation

Dreamsorcerer
Copy link
Member

Finally completing the review for #7265.
Have added a small fix and now I think this is correct. Will double check it tomorrow before merging.

DavidRomanovizc and others added 30 commits April 29, 2023 13:02
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@Dreamsorcerer Dreamsorcerer added the backport:skip Skip backport bot label Apr 21, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 21, 2024
CHANGES/7265.breaking.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 99.09091% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.61%. Comparing base (9b6f2c0) to head (cdd9ce0).
Report is 1 commits behind head on master.

Files Patch % Lines
aiohttp/http_parser.py 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8367      +/-   ##
==========================================
- Coverage   97.61%   97.61%   -0.01%     
==========================================
  Files         107      107              
  Lines       33092    33085       -7     
  Branches     3887     3875      -12     
==========================================
- Hits        32303    32296       -7     
  Misses        572      572              
  Partials      217      217              
Flag Coverage Δ
CI-GHA 97.53% <99.09%> (-0.01%) ⬇️
OS-Linux 97.19% <99.09%> (-0.01%) ⬇️
OS-Windows 95.60% <99.07%> (-0.01%) ⬇️
OS-macOS 96.85% <99.09%> (-0.01%) ⬇️
Py-3.10.11 95.45% <99.07%> (-0.01%) ⬇️
Py-3.10.14 96.99% <99.09%> (-0.01%) ⬇️
Py-3.11.9 97.19% <99.09%> (-0.01%) ⬇️
Py-3.12.3 97.31% <99.09%> (-0.01%) ⬇️
Py-3.8.10 95.37% <99.07%> (-0.01%) ⬇️
Py-3.8.18 96.85% <99.09%> (-0.01%) ⬇️
Py-3.9.13 95.42% <99.07%> (-0.01%) ⬇️
Py-3.9.19 96.96% <99.09%> (-0.01%) ⬇️
Py-pypy7.3.15 96.51% <99.09%> (-0.01%) ⬇️
VM-macos 96.85% <99.09%> (-0.01%) ⬇️
VM-ubuntu 97.19% <99.09%> (-0.01%) ⬇️
VM-windows 95.60% <99.07%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 1238f33 into master Apr 21, 2024
37 of 38 checks passed
@Dreamsorcerer Dreamsorcerer deleted the delete-size branch April 21, 2024 11:48
@Dreamsorcerer
Copy link
Member Author

@DavidRomanovizc Thanks for getting through that, turned out to be quite tricky in the end. If you're interested in picking up any other tasks, there should be plenty of easier ones that should be quick to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip Skip backport bot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants