Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests with unclosed warnings (#8391) #8392

Conversation

Dreamsorcerer
Copy link
Member

(cherry picked from commit 0ba6cf2)

@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 97.51%. Comparing base (17af047) to head (debc2c7).
Report is 2 commits behind head on 3.10.

Files Patch % Lines
tests/test_proxy_functional.py 38.46% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8392      +/-   ##
==========================================
+ Coverage   97.50%   97.51%   +0.01%     
==========================================
  Files         108      108              
  Lines       33294    33285       -9     
  Branches     3987     3997      +10     
==========================================
- Hits        32462    32459       -3     
+ Misses        608      602       -6     
  Partials      224      224              
Flag Coverage Δ
CI-GHA 97.42% <38.46%> (+0.01%) ⬆️
OS-Linux 97.10% <38.46%> (+0.01%) ⬆️
OS-Windows 94.70% <38.46%> (+0.01%) ⬆️
OS-macOS 96.77% <38.46%> (+0.02%) ⬆️
Py-3.10.11 96.88% <11.53%> (+<0.01%) ⬆️
Py-3.10.14 96.84% <11.53%> (+<0.01%) ⬆️
Py-3.11.9 97.07% <23.07%> (+<0.01%) ⬆️
Py-3.12.3 97.17% <23.07%> (+0.01%) ⬆️
Py-3.8.10 94.44% <19.23%> (+0.01%) ⬆️
Py-3.8.18 96.73% <19.23%> (+0.01%) ⬆️
Py-3.9.13 96.87% <26.92%> (+0.02%) ⬆️
Py-3.9.19 96.84% <26.92%> (+0.02%) ⬆️
Py-pypy7.3.15 96.40% <26.92%> (+0.02%) ⬆️
VM-macos 96.77% <38.46%> (+0.02%) ⬆️
VM-ubuntu 97.10% <38.46%> (+0.01%) ⬆️
VM-windows 94.70% <38.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit c215e56 into 3.10 Apr 29, 2024
32 of 34 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/0ba6cf26fa99c056e9b98a1f972a91b416850006/pr-8391 branch April 29, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant