-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for #8395 #8396
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8396 +/- ##
==========================================
- Coverage 97.64% 97.64% -0.01%
==========================================
Files 107 107
Lines 33057 33067 +10
Branches 3883 3885 +2
==========================================
+ Hits 32279 32288 +9
- Misses 561 562 +1
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 42906a6 on top of patchback/backports/3.9/42906a6e9ec8791678b636423657f621bfa0a39b/pr-8396 Backporting merged PR #8396 into master
🤖 @patchback |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 42906a6 on top of patchback/backports/3.10/42906a6e9ec8791678b636423657f621bfa0a39b/pr-8396 Backporting merged PR #8396 into master
🤖 @patchback |
What do these changes do?
Introduce a regression test to help fixing #8395.
Are there changes in behavior for the user?
No this is just a test.
Is it a substantial burden for the maintainers to support this?
Shouldn't be :) The idea here is to help with catching regressions like these in the future.
Related issue number
#8395
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.