620.bugfix program_name default value #621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the program path is too big, an error is thrown because it overflows the byte limit of a request to mysql. This change fixes this defining that only the last item of the path is the name of the program.
|
It is probably a better idea to just port the change from PyMySQL and not send this by default: PyMySQL/PyMySQL#755 |
|
do you want to adjust your PR to port this change? |
Nothing4You
added a commit
that referenced
this pull request
Jan 22, 2022
4 tasks
Nothing4You
added a commit
that referenced
this pull request
Jan 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When the program path is too big, an error is thrown because it overflows the byte limit of a request to mysql. This change fixes this defining that only the last item of the path is the name of the program.
Are there changes in behavior for the user?
When the program name includes its full path, it extracts only the program name.
Related issue number
#620
Checklist
CHANGESfolder