Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send sys.argv[0] as program_name to MySQL server by default #681

Merged
merged 1 commit into from
Jan 22, 2022

Conversation

Nothing4You
Copy link
Collaborator

@Nothing4You Nothing4You commented Jan 22, 2022

What do these changes do?

This ports PyMySQL's change: PyMySQL/PyMySQL#755

Are there changes in behavior for the user?

We no longer implicitly send sys.argv[0] to the DB server by default.
For the majority of users this should not be relevant, if you need this value you can still pass it explicitly.

Related issue number

fixes #620, closes #621

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@Nothing4You Nothing4You added this to the 1.0.0 milestone Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #681 (54865b2) into master (c1c2fb5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   83.56%   83.60%   +0.03%     
==========================================
  Files          12       12              
  Lines        2051     2049       -2     
  Branches      332      331       -1     
==========================================
- Hits         1714     1713       -1     
  Misses        266      266              
+ Partials       71       70       -1     
Flag Coverage Δ
ubuntu-latest_3.7_mariadb-10.2 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.3 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.4 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.5 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.6 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.7 82.31% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mysql-5.7 83.21% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.2 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.3 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.4 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.5 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.6 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mariadb-10.7 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mysql-5.7 83.60% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.2 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.3 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.4 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.5 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.6 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.7 82.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mysql-5.7 83.60% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiomysql/connection.py 77.35% <ø> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c2fb5...54865b2. Read the comment docs.

@Nothing4You Nothing4You merged commit 0a64588 into master Jan 22, 2022
@Nothing4You Nothing4You deleted the dont-send-program-name-by-default branch January 22, 2022 15:32
Nothing4You added a commit that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message by program name too big
1 participant