Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsa extras_require depending on PyMySQL[rsa] #733

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

Nothing4You
Copy link
Collaborator

What do these changes do?

Allow installing aiomysql[rsa] to depend on the supported PyMySQL[rsa] version.

Are there changes in behavior for the user?

no

Related issue number

fixes #557

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment to CHANGES.txt

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #733 (ccad9c4) into master (ffd346e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #733   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          35       35           
  Lines        5533     5533           
  Branches      941      941           
=======================================
  Hits         5138     5138           
  Misses        307      307           
  Partials       88       88           
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.3 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.4 89.39% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.5 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.6 89.37% <ø> (ø)
ubuntu-latest_3.10_mariadb-10.7 89.37% <ø> (ø)
ubuntu-latest_3.10_mysql-5.7 90.07% <ø> (ø)
ubuntu-latest_3.10_mysql-8.0 91.46% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.2 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.3 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.4 89.35% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.5 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.6 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mariadb-10.7 89.33% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-5.7 90.04% <ø> (ø)
ubuntu-latest_3.11-dev_mysql-8.0 91.43% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.2 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.3 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.4 88.79% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.5 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.6 88.77% <ø> (ø)
ubuntu-latest_3.7_mariadb-10.7 88.77% <ø> (ø)
ubuntu-latest_3.7_mysql-5.7 89.52% <ø> (ø)
ubuntu-latest_3.7_mysql-8.0 91.00% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.2 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.3 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.4 89.43% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.5 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.6 89.41% <ø> (ø)
ubuntu-latest_3.8_mariadb-10.7 89.41% <ø> (ø)
ubuntu-latest_3.8_mysql-5.7 90.11% <ø> (ø)
ubuntu-latest_3.8_mysql-8.0 91.49% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.2 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.3 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.4 89.28% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.5 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.6 89.26% <ø> (ø)
ubuntu-latest_3.9_mariadb-10.7 89.26% <ø> (ø)
ubuntu-latest_3.9_mysql-5.7 89.97% <ø> (ø)
ubuntu-latest_3.9_mysql-8.0 91.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd346e...ccad9c4. Read the comment docs.

@Nothing4You Nothing4You merged commit bf8b11e into master Feb 18, 2022
@Nothing4You Nothing4You deleted the fix-557 branch February 18, 2022 00:05
@Nothing4You Nothing4You added this to the 0.1 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an rsa extra require?
1 participant