Fix MySQL 5.7 tests #811
Merged
Fix MySQL 5.7 tests #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove our workaround for setting the socket path with docker-library/mysql#867 images without distro tag are now built on oracle linux by default. this change removed /etc/mysql/mysql.conf.d from the image, see also docker-library/mysql#876. this also means we no longer need to work around the socket path being overridden in another config file and we can use the same logic as on all other images.
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 92.76% 92.72% -0.04%
==========================================
Files 38 38
Lines 5569 5569
Branches 943 943
==========================================
- Hits 5166 5164 -2
- Misses 315 317 +2
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The latest MySQL 5.7 images changed the default distro from debian to oracle linux.
With this change our tests are failing, as the path for the custom config to enable a unix socket no longer exists.
With this change we also no longer need to work around the config shipped in the container messing with out drop-in config in
/etc/mysql/conf.d/, so we can remove the workaround formysql:5.7and use the same logic for all database containers.Are there changes in behavior for the user?
no