Update "oracle" variants to be the default variants #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Oracle Linux-based images: - are smaller (by a pretty non-trivial amount - nearly 100MiB) - support more architectures (arm64!) - are more supported/recommended by MySQL upstream I do not believe it is common for users to install additional packages in images that are `FROM mysql`, but if it is, the Debian-based images are not going away with this change (those users will just have to adapt - either by switching their package installations to Oracle-based packages or by using the Debian-based variants explicitly).
|
LOL, I just started making this exact same PR a second time:
These variants have been available since February (#680), and we're not planning to remove the Debian-based variants of 5.7 or 8.0 anytime soon (however, if there's ever an 8.1 or 9.0, that will likely be Oracle-only). IMO we should move forward with this on Tuesday of next week right after the US holiday. |
yosifkit
approved these changes
Jun 30, 2022
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jul 5, 2022
Changes: - docker-library/mysql@f8d76ae: Merge pull request docker-library/mysql#867 from infosiftr/oracle - docker-library/mysql@6cb7337: Merge pull request docker-library/mysql#866 from infosiftr/bullseye
Nothing4You
added a commit
to Nothing4You/aiomysql
that referenced
this pull request
Jul 7, 2022
… remove our workaround for setting the socket path with docker-library/mysql#867 images without distro tag are now built on oracle linux by default. this change removed /etc/mysql/mysql.conf.d from the image, see also docker-library/mysql#876. this also means we no longer need to work around the socket path being overridden in another config file and we can use the same logic as on all other images.
Nothing4You
added a commit
to aio-libs/aiomysql
that referenced
this pull request
Jul 7, 2022
… remove our workaround for setting the socket path (#811) with docker-library/mysql#867 images without distro tag are now built on oracle linux by default. this change removed /etc/mysql/mysql.conf.d from the image, see also docker-library/mysql#876. this also means we no longer need to work around the socket path being overridden in another config file and we can use the same logic as on all other images.
This was referenced Jul 7, 2022
BaurzhanSakhariev
pushed a commit
to crate/official-images
that referenced
this pull request
Jul 18, 2022
Changes: - docker-library/mysql@f8d76ae: Merge pull request docker-library/mysql#867 from infosiftr/oracle - docker-library/mysql@6cb7337: Merge pull request docker-library/mysql#866 from infosiftr/bullseye
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Oracle Linux-based images:
I do not believe it is common for users to install additional packages in images that are
FROM mysql, but if it is, the Debian-based images are not going away with this change (those users will just have to adapt - either by switching their package installations to Oracle-based packages or by using the Debian-based variants explicitly).