Fix Python 3.7.0 #9
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 19 25 +6
Branches 2 4 +2
=====================================
+ Hits 19 25 +6
Continue to review full report at Codecov.
|
|
It is fails for travis 3.7-dev, but works for local Python 3.7.0, so it depends right now on travis-ci/travis-ci#9815 |
.travis.yml
Outdated
| @@ -18,7 +22,7 @@ deploy: | |||
| provider: pypi | |||
| user: hellysmile | |||
There was a problem hiding this comment.
Let's also update to the new bot user
There was a problem hiding this comment.
Where I can find new bot credentials?
.travis.yml
Outdated
| - pip install -U setuptools | ||
| - pip install -U pip | ||
| - pip install -U wheel | ||
| - pip install -U tox | ||
| script: | ||
| - export TOXENV=py`python -c 'import sys; print("".join(map(str, sys.version_info[:2])))'` |
There was a problem hiding this comment.
I suggest you to use an approach, I'm demoing in multidict PR now.
There was a problem hiding this comment.
What about https://github.com/tox-dev/tox-travis ?
There was a problem hiding this comment.
have envlist = python in tox.ini and run just tox then.
tests/test_base.py
Outdated
|
|
||
|
|
||
| @pytest.mark.skipif( |
There was a problem hiding this comment.
Save this into a shortcut variable and reuse instead of copy-pasting.
tox.ini
Outdated
| py3{5,6} | ||
| skip_missing_interpreters = True | ||
| py3{5,6,7} | ||
| skip_missing_interpreters = False |
There was a problem hiding this comment.
Don't do this, since it's bad for local dev flow.
.travis.yml
Outdated
| - pip install -U setuptools | ||
| - pip install -U pip | ||
| - pip install -U wheel | ||
| - pip install -U tox | ||
| script: | ||
| - export TOXENV=py`python -c 'import sys; print("".join(map(str, sys.version_info[:2])))'` |
There was a problem hiding this comment.
Also just TOXENV=py should work.
There was a problem hiding this comment.
I have no idea how it should work, cuz we need explicit env namig
There was a problem hiding this comment.
Why? You don't. It will pick up whatever current python points to by default, but will allow -e py37-like stuff if you need.
|
|
||
| only_370 = pytest.mark.skipif( | ||
| not PY_370, | ||
| reason='Python>=3.7.0 do not need monkey patching', |
There was a problem hiding this comment.
This message is exactly the same as one on line 10. One of them is clearly wrong.
|
@webknjaz let's update credentials to new bot and publish new version? |
| @@ -14,6 +14,8 @@ after_success: | |||
| - pip install codecov | |||
| - codecov | |||
| cache: pip | |||
| env: | |||
| TOXENV: py | |||
There was a problem hiding this comment.
this is really, cool, but looks like a magic for me ;)
There was a problem hiding this comment.
It just matches any py* envs. Well, it could be omitted because it's default behavior.
But I normally don't even list envs. envlist = python is enough to make everything work without extra configuration.
|
@hellysmile please go ahead and update creds, I'm traveling today and likely won't have time for that. |
|
I'm anxiously waiting for this fix. |
|
@hellysmile I've updated creds. Feel free to release dist. |
Closes #8