Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a new URL if fragment unchanged #384

Merged
merged 5 commits into from
Nov 27, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 27, 2019

Supersedes #292

Co-Authored-By: Ryan Northey ryan@synca.io

@asvetlov asvetlov mentioned this pull request Nov 27, 2019
5 tasks
@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #384 into master will increase coverage by 0.62%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #384      +/-   ##
========================================
+ Coverage   99.37%   100%   +0.62%     
========================================
  Files           2      2              
  Lines         637    640       +3     
  Branches      145    146       +1     
========================================
+ Hits          633    640       +7     
+ Misses          1      0       -1     
+ Partials        3      0       -3
Impacted Files Coverage Δ
yarl/__init__.py 100% <100%> (ø) ⬆️
yarl/quoting.py 100% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 089eeac...766acbc. Read the comment docs.

@asvetlov asvetlov merged commit d0752ca into master Nov 27, 2019
@asvetlov asvetlov deleted the phlax-no-new-if-fragment-unchanged branch November 27, 2019 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants