Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for empty host #821 #822

Merged
merged 4 commits into from
Nov 19, 2023
Merged

Add test for empty host #821 #822

merged 4 commits into from
Nov 19, 2023

Conversation

kenballus
Copy link
Contributor

Adds a test to ensure that empty hosts are handled in the correct way, as requested in #821.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5659e3c) 99.74% compared to head (fa4091f) 99.74%.
Report is 1 commits behind head on master.

❗ Current head fa4091f differs from pull request most recent head a1ffbdf. Consider uploading reports for the commit a1ffbdf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_url_parsing.py Outdated Show resolved Hide resolved
@webknjaz webknjaz merged commit 3e572c9 into aio-libs:master Nov 19, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants