Some changes #112
Merged
Some changes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gabbhack
commented
Mar 22, 2019
•
gabbhack
commented
- Add more await in RedisStorage and RedisStorage2
- Replace "send" with "reply" in some method's names
- Add "answer" method to Message
- Add "lazy_gettext" method to I18nMiddleware
- Reformat code
All reply-related methods used the prefix "reply", except for animation, venue and contact, which could be confusing
This is the "reply" method with the name "answer" and the default argument reply=False
Now introspection takes place during handler registration. I am not sure about this implementation.
JrooTJunior
requested changes
Mar 30, 2019
- Add more answer_* methods - Move some methods for beauty
Now the func, specs and filters are put in the dataclass
JrooTJunior
approved these changes
Mar 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.