Automatically Resolve Update Types in start_polling method.
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Changelog found.Thank you for adding a description of the changes |
Olegt0rr
reviewed
Jun 2, 2023
aiogram/dispatcher/dispatcher.py
Outdated
| @@ -450,7 +451,7 @@ async def start_polling( | |||
| polling_timeout: int = 10, | |||
| handle_as_tasks: bool = True, | |||
| backoff_config: BackoffConfig = DEFAULT_BACKOFF_CONFIG, | |||
| allowed_updates: Optional[List[str]] = None, | |||
| allowed_updates: Optional[List[str]] = UNSET_TYPE, | |||
There was a problem hiding this comment.
Seems like it replaced UNSET, which is not available in the current version.
Latand
changed the title
auto_resolve_update_types argument to start_polling method.start_polling method.
|
Merged outside of this pull-request with small changes in due to incorrect type-hints is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the method
dp.resolve_used_update_typescan be improved for better readability and understandability, a better name for this function could be "get_registered_event_names", or "get_registered_update_types".So I changed the logic, that the dispatcher would automatically collect the update types used in handlers, if
allowed_updatesparameter is not specified.Type of change
Please delete options that are not relevant.
Checklist: