Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some typos in documentation #1268

Merged
merged 3 commits into from Aug 16, 2023
Merged

Conversation

wakaree
Copy link
Contributor

@wakaree wakaree commented Aug 16, 2023

Description

I found 2 issues in documentation and fixed it:

  • In the i18n LazyProxy usage example, there was a comparison of the lowercase text with "My menu entry".
  • The bound_filter parameter has been removed from the TelegramEventObserver filter method, so this parameter should not be in the docstring.

Type of change

  • Documentation (typos, code examples or any documentation update)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Aug 16, 2023
@github-actions
Copy link

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1268 (74eee59) into dev-3.x (8ff992b) will not change coverage.
Report is 1 commits behind head on dev-3.x.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          364       364           
  Lines         9313      9313           
=========================================
  Hits          9313      9313           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiogram/dispatcher/event/telegram.py 100.00% <ø> (ø)

@JrooTJunior JrooTJunior merged commit 2093b45 into aiogram:dev-3.x Aug 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants