Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added absent params for button builders #1304

Merged
merged 3 commits into from Sep 19, 2023

Conversation

Olegt0rr
Copy link
Contributor

Description

Added params hints for button builders

Fixes #1303

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • Operating System: macOS
  • Python version: 3.11

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr added bug Something is wrong with the framework 3.x Issue or PR for stable 3.x version labels Sep 18, 2023
@Olegt0rr Olegt0rr self-assigned this Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1304 (237e95f) into dev-3.x (995a0d7) will not change coverage.
Report is 5 commits behind head on dev-3.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          369       369           
  Lines         9412      9412           
=========================================
  Hits          9412      9412           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiogram/utils/keyboard.py 100.00% <ø> (ø)

@Olegt0rr Olegt0rr marked this pull request as ready for review September 18, 2023 08:37
@Olegt0rr Olegt0rr requested a review from a team September 18, 2023 08:37
@Olegt0rr Olegt0rr assigned JrooTJunior and unassigned Olegt0rr Sep 18, 2023
@JrooTJunior JrooTJunior merged commit 83a01f0 into dev-3.x Sep 19, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inline]KeyboardBuilder does not support web_app
3 participants