Fixed ResourceWarnings in tests #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the pytest's configuration file, `pyproject.toml`, to remove filterwarnings settings. It also makes changes in various test files; the Redis isolation test is now using the provided `redis_storage` fixture instead of setting up its own connection, pytest.mark.filterwarnings is no longer used in `test_isolation.py` and `test_aiohttp_session.py` properly closes off sessions.
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1366 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 369 369
Lines 9448 9448
=========================================
Hits 9448 9448
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed ResourceWarning in tests, modified the pytest's configuration file,
pyproject.toml, to remove filterwarnings settings. It also makes changes in various test files; the Redis isolation test is now using the providedredis_storagefixture instead of setting up its own connection, pytest.mark.filterwarnings is no longer used intest_isolation.pyandtest_aiohttp_session.pyproperly closes off sessions.Fixes #1320