Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default LinkPreviewOptions JSON serialization #1419

Merged
merged 2 commits into from Feb 17, 2024

Conversation

JrooTJunior
Copy link
Member

@JrooTJunior JrooTJunior commented Feb 17, 2024

Description

Fixed JSON serialization of the LinkPreviewOptions class while it is passed
as bot-wide default options.

@JrooTJunior JrooTJunior added the bug Something is wrong with the framework label Feb 17, 2024
Copy link

✔️ Changelog found.

Thank you for adding a description of the changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eef50a2) 100.00% compared to head (6312959) 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1419   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          412       412           
  Lines        10655     10657    +2     
=========================================
+ Hits         10655     10657    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
aiogram/client/session/base.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior mentioned this pull request Feb 17, 2024
6 tasks
@JrooTJunior JrooTJunior merged commit 53849b0 into dev-3.x Feb 17, 2024
26 checks passed
@JrooTJunior JrooTJunior deleted the bugfix/default-link-preview-options branch February 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant