New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis storage update #145

Merged

JrooTJunior merged 4 commits into aiogram:dev-2.x from gabbhack:redis_storage

Jun 28, 2019

Contributor

gabbhack commented Jun 27, 2019 •

edited

Description

Added ttl settings in RedisStorage2
Fixed update_bucket method in RedisStorage2
Updated docstrings

Fixes #139

Type of change

This change requires a documentation update
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Copy files from gist
Deploy it to heroku
Profit

Test Configuration:

Heroku add-ons: Heroku redis
requirements: aioredis
Python version: 3.7.3

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Gabben added 4 commits

June 27, 2019 19:34


          Add "expire" argument

c6accd1

Add "expire" argument to all set_ and update_ methods in RedisStorage2


          Update redis.py

e284294

Update docstrings


          Fix update_bucket

8a819eb


          Update redis.py

607e3ea

gabbhack commented

View reviewed changes

Contributor Author

gabbhack left a comment

aiogram_ru/67491

JrooTJunior approved these changes

View reviewed changes

JrooTJunior merged commit 0c73223 into aiogram:dev-2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment