Fail redis and mongo tests if incorrect URI provided + some storages tests refactoring #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default serverSelectionTimeoutMS=30000. This is too much
If incorrect URIs provided to "--redis" and/or "--mongo" options
tests should fail with ERRORs instead of skipping.
Otherwise the next scenario is possible:
1) developer breaks RedisStorage and/or MongoStorage code
2) tests are run with incorrect redis and/or mongo URIs
provided by "--redis" and "--mongo" options.
For example, wrong port specified.
3) tests pass because skipping doesn't fail tests run
4) developer or reviewer doesn't notice
that redis and/or mongo tests were skipped
5) broken code gets in codebase
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1510 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 436 436
Lines 11294 11294
=========================================
Hits 11294 11294
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Olegt0rr
requested changes
Jun 13, 2024
Olegt0rr
reviewed
Jun 13, 2024
This reverts commit d88b7ec.
The default 30s timeout is too long
Done |
Olegt0rr
requested changes
Jun 14, 2024
Olegt0rr
approved these changes
Jun 16, 2024
JrooTJunior
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Thanks for your contribution.
I will update the changelog message and category, this change does not affect the functionality of the framework, but improves the development process of the framework itself, so these changes should be marked as "misc" and not as "bugfixes".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If incorrect URIs provided to "--redis" and/or "--mongo" options tests should fail with errors instead of skipping.
Otherwise the next scenario is possible:
Checklist: