Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo storage #153

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Mongo storage #153

merged 2 commits into from
Aug 4, 2019

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Jul 8, 2019

Description

Added Mongo storage support based on aiomongo

@Olegt0rr Olegt0rr changed the title Mongo Mongo storage Jul 8, 2019
@Birdi7
Copy link
Contributor

Birdi7 commented Jul 10, 2019

Last commit is 2 year ago at aiomongo. Is this fine?

@JrooTJunior
Copy link
Member

Is Motor has the same interface? Maybe this storage can be maked more universally for usage with different drivers. Or maybe can be splitted into different storages like MotorsMongoStorage and AioMongoStorage.

Because Motor looks more reliable

@Olegt0rr
Copy link
Contributor Author

Last commit is 2 year ago at aiomongo. Is this fine?

Not aiomongo works fine and it's enought for me.
I'm not sure about motor speed. 2 years ago aiomongo was more faster than motor (look at the benchmarks).

If you can make fresh comparison of motor and aiomongo - please, do it.

@JrooTJunior
Copy link
Member

I'll merge this PR but after that i rename module from mongo to aiomongo and after that add the motor version of this storage because Motor is official library and is more popular

@JrooTJunior JrooTJunior merged commit 5d223f5 into aiogram:dev-2.x Aug 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants