Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aiogram/utils/auth_widget.py #190

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Refactor aiogram/utils/auth_widget.py #190

merged 1 commit into from
Aug 16, 2019

Conversation

mahenzon
Copy link
Contributor

Description

Refactor auth_widget.py

Type of change

  • Refactor

How Has This Been Tested?

  • Unit tests

Checklist:

  • My code follows the style guidelines of this project (sort of)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (None)
  • My changes generate no new warnings - lol generate (DeprecationWarning)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check_token is used in BaseBot class.

aiogram/aiogram/bot/base.py

Lines 268 to 269 in 64000e0

def check_auth_widget(self, data):
return check_token(data, self.__token)

Here you will beed to change the called function name because it generates new warning.

+ fix check auth widget token in BaseBot, fix tests
@mahenzon
Copy link
Contributor Author

Fixed
Also minor refactored tests

@JrooTJunior JrooTJunior merged commit b8dfa73 into dev-2.x Aug 16, 2019
@JrooTJunior JrooTJunior deleted the 2.x-refactor branch May 2, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants