Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacklevel arguments in renamed arguments in the dispatcher #196

Merged
merged 2 commits into from
Aug 24, 2019
Merged

Fix stacklevel arguments in renamed arguments in the dispatcher #196

merged 2 commits into from
Aug 24, 2019

Conversation

Birdi7
Copy link
Contributor

@Birdi7 Birdi7 commented Aug 24, 2019

Description

Fix the values of stack levels in 3 methods in the Dispatcher.
Here is before:
And this is after:
Used listing is here
The output points to the actual line where the function was invoked with the deprecated argument, so it will be easier to debug.
Also, I replaced the positional arguments to kwargs

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior merged commit 172d834 into aiogram:dev-2.x Aug 24, 2019
@Birdi7 Birdi7 deleted the fix-rename-stacklevel branch August 25, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants