Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot API 4.5 (without MarkdownV2) #250

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Bot API 4.5 (without MarkdownV2) #250

merged 4 commits into from
Dec 31, 2019

Conversation

gabbhack
Copy link
Contributor

@gabbhack gabbhack commented Dec 31, 2019 •
edited

Description

Bot API 4.5

  • New file_unique_id, small_file_unique_id, big_file_unique_id, custom_title, slow_mode_delay fields
  • New setChatAdministratorCustomTitle method
  • MarkdownV2 style will add @JrooTJunior .

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It hasn't been tested.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gabbhack gabbhack changed the title Bot API 4.5 Bot API 4.5 (without MarkdownV2) Dec 31, 2019
prostomarkeloff
prostomarkeloff reviewed Dec 31, 2019
View reviewed changes
Copy link
Contributor

@prostomarkeloff prostomarkeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good changes. i love it.

prostomarkeloff
prostomarkeloff approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@prostomarkeloff prostomarkeloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all changes are good. i think it's ready to merge.

@JrooTJunior JrooTJunior added this to the 2.5 milestone Dec 31, 2019
@JrooTJunior JrooTJunior merged commit b66ad87 into aiogram:dev-2.x Dec 31, 2019
@JrooTJunior JrooTJunior mentioned this pull request Dec 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

@prostomarkeloff prostomarkeloff prostomarkeloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabbhack @JrooTJunior @prostomarkeloff