Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text decorations. Fix 'mention' generator and emoji offsets. #315

Merged
merged 1 commit into from May 1, 2020

Conversation

JrooTJunior
Copy link
Member

Description

  • Updated text decorations
  • Fixed mention generation with nested entities @username
  • Fixed emoji offset

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior added the enhancement Make it better! label May 1, 2020
@JrooTJunior JrooTJunior added this to the 3.0 milestone May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #315 into dev-3.x will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #315   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          210       210           
  Lines         3982      4014   +32     
=========================================
+ Hits          3982      4014   +32     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)
Impacted Files Coverage Δ
aiogram/utils/markdown.py 100.00% <100.00%> (ø)
aiogram/utils/text_decorations.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit 8d842ea into dev-3.x May 1, 2020
@JrooTJunior JrooTJunior deleted the dev-3.x-fix-text-decorations branch May 1, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant