Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug IDFilter checking message from channel #376

Merged
merged 2 commits into from Jul 5, 2020
Merged

fix: bug IDFilter checking message from channel #376

merged 2 commits into from Jul 5, 2020

Conversation

Birdi7
Copy link
Contributor

@Birdi7 Birdi7 commented Jul 3, 2020

Description

IDFilter checks correctly message from channel. For previous behaviour, check the corresponding issue

Fixes #375

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit-test was added

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MasterGroosha
Copy link
Contributor

Looks good to me

@Birdi7 Birdi7 requested a review from JrooTJunior July 3, 2020 08:16
@JrooTJunior JrooTJunior added the enhancement Make it better! label Jul 5, 2020
@JrooTJunior JrooTJunior added this to the 2.10 milestone Jul 5, 2020
@JrooTJunior JrooTJunior merged commit f904292 into aiogram:dev-2.x Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

Assignees
No one assigned
Labels
enhancement Make it better!
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

chat_id filter in handler doesn't work with channels.
3 participants
@Birdi7 @MasterGroosha @JrooTJunior