Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for text decoration pre() bug #597

Merged
merged 1 commit into from Jun 6, 2021
Merged

fix for text decoration pre() bug #597

merged 1 commit into from Jun 6, 2021

Conversation

p82o
Copy link

@p82o p82o commented Jun 4, 2021

Description

This fix adds '\n' symbols at begin and end of inserted text to pre() formatter in Makdown(V2) style as it described in official documentation.

Fixes #596
Fixes #481

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@evgfilim1 evgfilim1 added the bug Something is wrong with the framework label Jun 4, 2021
@evgfilim1 evgfilim1 mentioned this pull request Jun 4, 2021
Copy link
Contributor

@evgfilim1 evgfilim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for PR.

@JrooTJunior I think this might break existing workarounds lol, is it ok?
IMO it's ok as this behavior is a bug, we'll post changelog anyway, so it won't be so hard 😅

@JrooTJunior JrooTJunior merged commit 02cd42a into aiogram:dev-2.x Jun 6, 2021
@evgfilim1 evgfilim1 added this to the 2.14 milestone Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text decoration pre() bug Losing first word of message with Markdown pre encoding
3 participants