Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: renamed getChatMembersCount to getChatMemberCount #614

Merged
merged 1 commit into from Jun 29, 2021

Conversation

dmytrohoi
Copy link

@dmytrohoi dmytrohoi commented Jun 28, 2021

Description

Add required changes to cover API 5.3.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dmytrohoi dmytrohoi mentioned this pull request Jun 28, 2021
11 tasks
@evgfilim1 evgfilim1 added the api Issues or new features of Bot API label Jun 29, 2021
@JrooTJunior JrooTJunior merged commit 1530904 into aiogram:dev-2.x-api-5.3 Jun 29, 2021
JrooTJunior added a commit that referenced this pull request Jul 4, 2021
* docs: api version update

* feat: personalized commands

* feat: custom placeholders

* refactor: ChatMember split

* fix: old names for ChatMemberStatus

* refactor: renamed kickChatMember to banChatMember

* style: align params

* refactor: renamed getChatMembersCount to getChatMemberCount (#614)

* feat: resolve ChatMember

* refactor: renamed BotCommandScopeTypes (similar to code style)

* refactor: resolve is a static method

* Construct BotCommandScope from type

* Make BotCommandScope classmethod instead of method

* Use classmethod for ChatMember resolve method

Co-authored-by: Hoi Dmytro <dmytro.hoi@gmail.com>
Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues or new features of Bot API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants