-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RedisStorage major fixes + tests updates #676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darksidecat
suggested changes
Aug 30, 2021
See that redis_storage_2 tests failing with self = <aiogram.contrib.fsm_storage.redis.AioRedisAdapterV1 object at 0x7f78aa61c9d0>
name = 'fsm:1234:1234:data', kwargs = {}
async def get(self, name, **kwargs):
> return await self._redis.get(name, encoding="utf8", **kwargs)
E AttributeError: 'NoneType' object has no attribute 'get'
../aiogram/contrib/fsm_storage/redis.py:310: AttributeError Seems like |
@darksidecat, fixed, try again :) |
Olegt0rr
changed the title
Redis async close + tests update
RedisStorage major fixes + tests updates
Sep 1, 2021
JrooTJunior
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forget to add
async
for Redis .close() coro.Thanks @darksidecat for comment #649 (review)
By the way fixed some bugs and fixed tests.
Sorry for large PR, but only merge of all of this issue fixes make able to test redis support correctly.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: