Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #665, add separate parametrs for saving to directory and file #677

Merged
merged 5 commits into from
Sep 5, 2021

Conversation

darksidecat
Copy link
Contributor

Description

Fix dirs creating, add separate parametrs for saving to directory and file
The depracation mark on destination parametr is negotiable.

Fixes #665

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run local tests
  • Manual testing in bot

Test Configuration:

  • Operating System: Win10
  • Python version: 3.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr added the bug Something is wrong with the framework label Sep 1, 2021
@JrooTJunior JrooTJunior merged commit 358ecc7 into aiogram:dev-2.x Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't download any file to custom folder
3 participants