Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bot.download_file aliases ability to save files to a directory and automatically create directories #694

Merged
merged 3 commits into from Nov 6, 2021

Conversation

darksidecat
Copy link
Contributor

@darksidecat darksidecat commented Sep 19, 2021

Description

  • add the ability to save files to a directory with path completion based on file.file_path,
  • add an option to automatically create directories in the file path

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add tests and run locally
  • Manual testing (not yet)

Test Configuration:

  • Operating System: Win 10
  • Python version: 3.9.6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

darksidecat and others added 3 commits September 19, 2021 20:17
* add the ability to save files to a directory with path completion based on file_path,
* add an option to automatically create directories in the file path
@JrooTJunior JrooTJunior merged commit b98ec3e into aiogram:dev-2.x Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants