Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes for connectors #191

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Bugfixes for connectors #191

merged 9 commits into from
Nov 15, 2023

Conversation

josvandervelde
Copy link

@josvandervelde josvandervelde commented Nov 15, 2023

  1. Updating example connector resources, to include all fields (mainly educational resource json)
  2. Bugfixes for HuggingFace, Openml and Zenodo. They all run fine now.
  3. To make that possible, I changed all NamedRelations to be always lowercase. E.g. keyword. This means that keyword "AI" is changed into "ai". This fixes some weird errors --> using mysql we got an integrity error if you first add "AI" and then "ai", although "SELECT * FROM keyword WHERE name = "AI"` doesn't retrieve the keyword with name "ai".
  4. Some quality of life improvements: added profiles to the docker compose (making it easy to not run the connectors), and throwing existing state of connectors away if the database is empty

In another PR I'll fix the "Permission denied" errors that you get when running the code for the first time.

README.md Show resolved Hide resolved
Copy link
Collaborator

@Taniya-Das Taniya-Das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@josvandervelde josvandervelde merged commit 1b4e53b into develop Nov 15, 2023
1 check passed
@josvandervelde josvandervelde deleted the bugfix/connector-problems branch November 15, 2023 15:16
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants