Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand sync statistics for tracking fast sync #837

Closed
AlexandraRoatis opened this issue Feb 25, 2019 · 0 comments
Closed

Expand sync statistics for tracking fast sync #837

AlexandraRoatis opened this issue Feb 25, 2019 · 0 comments
Labels
enhancement New feature or request feature
Milestone
0.4.0

Comments

@AlexandraRoatis
Copy link
Contributor

Description

The sync statistics currently track status, block headers, and block bodies messages. The fast sync implementation introduces three more types of requests: full blocks, receipts and trie data.

Expanding the sync statistics for tracking fast sync involves the following subpoints:

  1. Add BLOCKS, RECEIPTS and TRIE_DATA to the enum RequestType.
  2. Refactor the ResponseStatsTracker class to use the enum defined above and avoid code repetition.
  3. Expand request tracking for the new types, i.e. functionality using the RequestCounter.
  4. Log statistics regarding the new types of messages from the corresponding handlers/tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
3 participants
@beidouz @AlexandraRoatis @AionJayT