Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify / streamline data types #277

Open
maxheld83 opened this issue Sep 3, 2015 · 2 comments
Open

simplify / streamline data types #277

maxheld83 opened this issue Sep 3, 2015 · 2 comments
Milestone

Comments

@maxheld83
Copy link
Collaborator

we currently have a lot of especially dataframes in qmethod, where arguably, matrices would do.

I'm not quite sure what the pros and cons are (I remember that one should take the "simplest" data type possible) for dataframes vs. matrices, but we might want to think about making this consistent.

It's not a dramatic issue per se, but it might make future developments and testing more robust and easier, maybe give a cleaner codebase.

@aiorazabala
Copy link
Owner

Related to #239

@aiorazabala
Copy link
Owner

Changed from data.frame to matrix:

  • loadings,
  • flagged,
  • general characteristics:SD,

as per commit fa26315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants