feat(AIP-8): add requirement for counterexamples #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should / should not guidance in the AIPs is vague, and leaves the exercise of determining whether the guidance should be ignored completely up to the reader. Adding clear examples will help clarify the scenarios where it makes sense to ignore the guidance.
bgrant0607
reviewed
May 23, 2023
better wording.
|
@andrei-scripniciuc can you take a look? I think this is good guidance for the AIPs. |
andrei-scripniciuc
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should / should not guidance in the AIPs is vague, and leaves
the exercise of determining whether the guidance should be ignored
completely up to the reader.
Adding clear examples will help clarify the scenarios where it
makes sense to ignore the guidance.