Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIP-142] Approve the dates/times AIP. #171

Merged
merged 2 commits into from
Jul 22, 2019
Merged

[AIP-142] Approve the dates/times AIP. #171

merged 2 commits into from
Jul 22, 2019

Conversation

lukesneeringer
Copy link
Contributor

Fixes #64.

@lukesneeringer lukesneeringer requested a review from a team July 19, 2019 03:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2019
jskeet
jskeet approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, but you might want to wait for others.

@jgeewax
Update 0142.md (#178)
0951982 
* Update 0142.md

Added section on relative timestamps (for audiosegment) and other edits.

* Update 0142.md

* Update 0142.md

* Update 0142.md
@lukesneeringer lukesneeringer merged commit 656e70e into master Jul 22, 2019
@lukesneeringer lukesneeringer deleted the aip-142-approval branch July 22, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

@jgeewax jgeewax jgeewax approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AIP-142] Time and Duration
4 participants
@lukesneeringer @jskeet @jgeewax @googlebot