Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equals type_checking relaxed and simplifier walk_equals improved #457

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

Framba-Luca
Copy link
Contributor

No description provided.

@Framba-Luca Framba-Luca self-assigned this Jul 17, 2023
@Framba-Luca
Copy link
Contributor Author

Solves #454

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.02 🎉

Comparison is base (be401c4) 85.05% compared to head (618e286) 85.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   85.05%   85.07%   +0.02%     
==========================================
  Files         198      198              
  Lines       25722    25742      +20     
==========================================
+ Hits        21878    21901      +23     
+ Misses       3844     3841       -3     
Impacted Files Coverage Δ
unified_planning/model/walkers/simplifier.py 94.57% <85.71%> (-0.26%) ⬇️
unified_planning/model/walkers/type_checker.py 90.94% <85.71%> (+0.18%) ⬆️
unified_planning/test/test_pddl_io.py 99.59% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alvalentini alvalentini merged commit 83d1b5e into master Jul 19, 2023
8 checks passed
@alvalentini alvalentini deleted the typing-fix branch July 19, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants