Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to TILs in the PDDLWriter #543

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Add support to TILs in the PDDLWriter #543

merged 4 commits into from
Jan 15, 2024

Conversation

alvalentini
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (da8ab70) 84.96% compared to head (51f5adc) 85.00%.
Report is 11 commits behind head on master.

Files Patch % Lines
unified_planning/io/pddl_reader.py 66.66% 5 Missing ⚠️
unified_planning/io/pddl_writer.py 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   84.96%   85.00%   +0.03%     
==========================================
  Files         200      200              
  Lines       26433    26469      +36     
==========================================
+ Hits        22458    22499      +41     
+ Misses       3975     3970       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

unified_planning/io/pddl_writer.py Outdated Show resolved Hide resolved
unified_planning/io/pddl_writer.py Outdated Show resolved Hide resolved
unified_planning/io/pddl_writer.py Outdated Show resolved Hide resolved
Copy link
Member

@arbimo arbimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just suggested using timed-initial-effect has feature name to make it less ambiguous and avoid potential clashes.

Right now there is no place for it in the documentation but it should be mentioned in a future "advanced temporal modeling features".

unified_planning/io/pddl_writer.py Outdated Show resolved Hide resolved
@arbimo arbimo merged commit c7d0e01 into master Jan 15, 2024
8 checks passed
@arbimo arbimo deleted the fix-tils-pddl-writer branch January 15, 2024 08:22
@alvalentini alvalentini linked an issue Jan 16, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write PDDL with Timed Initial Literals
3 participants