deps: require numpy version 1.X.Y #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbimo
force-pushed
the
fix/numpy-version
branch
from
22e274e
to
5cccdde
Compare
arbimo
force-pushed
the
fix/numpy-version
branch
from
5cccdde
to
027ee65
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 85.34% 85.34%
=======================================
Files 202 202
Lines 27272 27272
=======================================
Hits 23275 23275
Misses 3997 3997 ☔ View full report in Codecov by Sentry. |
|
Thanks for this Arthur. Did you discover whcih pair of deps caused this (so that we can monitor them)? |
|
No, but @nicola-gigante is I think the one who delved the most into this issue and may have more insights. Note that we faced the same problem also for doc generation, where the dependencies are quite different. |
|
@mikand if you have access to the old CI logs, you should see the name of the offending module in the Python stack trace, I think. |
alvalentini
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent release of numpy 2.0 seem to break some of our dependencies.
If you were to re-run the CI on master before this commit, it would fail due to incompatible depenndencies.
This introduces a work around to ensure that we remain on a 1.X.Y version of numpy. I expect this to be removable once the ecosystem fixes their required dependencies.